From baa03b8cf5bb7fb765761c495abc58ec97875673 Mon Sep 17 00:00:00 2001 From: Mavlushechka Date: Thu, 29 Sep 2022 23:11:07 +0500 Subject: Move often used config data to variables --- src/test/java/com/mavlushechka/a1qa/TestCase1.java | 34 +++++++--------------- 1 file changed, 10 insertions(+), 24 deletions(-) (limited to 'src/test') diff --git a/src/test/java/com/mavlushechka/a1qa/TestCase1.java b/src/test/java/com/mavlushechka/a1qa/TestCase1.java index e26ce84..b14eac6 100644 --- a/src/test/java/com/mavlushechka/a1qa/TestCase1.java +++ b/src/test/java/com/mavlushechka/a1qa/TestCase1.java @@ -23,33 +23,19 @@ public class TestCase1 extends BaseTest { homePage.clickNextPageButton(); GamePage gamePage = new GamePage(); - String randomUpperText = StringUtils.generateRandomText( - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersLowerBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersUpperBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.length")) - ).toUpperCase(); + int randomTextLettersLowerBound = Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersLowerBound")); + int randomTextLettersUpperBound = Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersUpperBound")); + int randomTextLength = Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.length")); + int randomNumberMin = Integer.parseInt(JSONParser.parse("config", "integerUtils.randomNumberMin")); + int randomNumberMax = Integer.parseInt(JSONParser.parse("config", "integerUtils.randomNumberMax")); + String randomUpperText = StringUtils.generateRandomText(randomTextLettersLowerBound, randomTextLettersUpperBound, randomTextLength).toUpperCase(); User user = new User( new Email( - StringUtils.generateRandomText( - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersLowerBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersUpperBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.length")) - ) + randomUpperText, - StringUtils.generateRandomText( - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersLowerBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersUpperBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.length")) - ), - Domain.values()[IntegerUtils.getRandomNumber(Integer.parseInt(JSONParser.parse("config", "integerUtils.randomNumberMin")), Domain.values().length)] + StringUtils.generateRandomText(randomTextLettersLowerBound, randomTextLettersUpperBound, randomTextLength) + randomUpperText, + StringUtils.generateRandomText(randomTextLettersLowerBound, randomTextLettersUpperBound, randomTextLength), + Domain.values()[IntegerUtils.getRandomNumber(randomNumberMin, Domain.values().length)] ), - StringUtils.generateRandomText( - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersLowerBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.lettersUpperBound")), - Integer.parseInt(JSONParser.parse("config", "randomTextGenerator.length")) - ) + randomUpperText + IntegerUtils.getRandomNumber( - Integer.parseInt(JSONParser.parse("config", "integerUtils.randomNumberMin")), - Integer.parseInt(JSONParser.parse("config", "integerUtils.randomNumberMax")) - ) + StringUtils.generateRandomText(randomTextLettersLowerBound, randomTextLettersUpperBound, randomTextLength) + randomUpperText + IntegerUtils.getRandomNumber(randomNumberMin, randomNumberMax) ); Assert.assertTrue(gamePage.isOpened(), "This is not the " + gamePage.getName() + "."); Assert.assertTrue(gamePage.isFirstCardFormOpened(), "The first card is not opened."); -- cgit v1.2.3