From 6aae55e910771d388c5d198524f5872eee904307 Mon Sep 17 00:00:00 2001 From: Mavlushechka Date: Thu, 22 Sep 2022 00:15:33 +0500 Subject: Add checking visibility of an element before finding the element in BaseElement class --- src/main/java/com/mavlushechka/a1qa/elements/BaseElement.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/mavlushechka/a1qa/elements/BaseElement.java b/src/main/java/com/mavlushechka/a1qa/elements/BaseElement.java index 8a7408d..29666be 100644 --- a/src/main/java/com/mavlushechka/a1qa/elements/BaseElement.java +++ b/src/main/java/com/mavlushechka/a1qa/elements/BaseElement.java @@ -41,17 +41,13 @@ public abstract class BaseElement { } public boolean isVisible() { - WebElement webElement = find(); - LoggerUtils.info("Getting visibility of the \"" + name + "\" element."); - return WebDriverWaitFactory.createWebDriverWait().until(ExpectedConditions.visibilityOf(webElement)).isDisplayed(); + return WebDriverWaitFactory.createWebDriverWait().until(ExpectedConditions.visibilityOfElementLocated(locator)).isDisplayed(); } public boolean isInvisible() { - WebElement webElement = find(); - LoggerUtils.info("Getting invisibility of the \"" + name + "\" element."); - return WebDriverWaitFactory.createWebDriverWait().until(ExpectedConditions.invisibilityOf(webElement)); + return WebDriverWaitFactory.createWebDriverWait().until(ExpectedConditions.invisibilityOfElementLocated(locator)); } public String getName() { @@ -73,6 +69,7 @@ public abstract class BaseElement { } protected WebElement find() { + isVisible(); LoggerUtils.info("Finding the \"" + name + "\" element."); return WebDriverUtils.findElement(locator); } -- cgit v1.2.3